advancedxy commented on PR #8259: URL: https://github.com/apache/iceberg/pull/8259#issuecomment-1741674765
> @advancedxy, thanks for your patience on this. I'm going to be looking at it more once the 1.4 release is out. That sounds reasonable and great to me. > I have a couple of things that I'm thinking through on this: > > * If we're updating the function, should we use a faster algorithm like XXH? If we are going to add `bucketV2` as the new bucket function for both single-arg and multi-arg parameters. We can certainly use a faster/new hash algorithm. > * Should we make hash(str) and hash(int) the same to enable type promotion? Currently, I don't think we can promote int to str due to the truncate/bucket(original) transform since we cannot produce same partition ing value. Unless we add more checks and restrictions about type promotion. I will also put more thinkings in this, and let's discuss after 1.4 is released . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
