bitsondatadev commented on PR #8659:
URL: https://github.com/apache/iceberg/pull/8659#issuecomment-1741530893

   
   RE: @RussellSpitzer cc: @ajantha-bhat 
   
   > How should we be reviewing this? What is new, what is old? Is it just 
style and build?
    
   All of this is a complete copy of the words (no content changed) of the 
existing site. So I would not focus on the words. There were quite a few broken 
links on the site that I decided to fix and had to in order to enable the 
interlinking between the static docs and the versioned docs.
   
   So, I would not be reviewing the actual words, or we'll be fixing the entire 
grammar and misspellings that already exist in the docs today. That will have 
it's own PR after this.
   
   The best way to test this is to understand [the proposed build process and 
how it 
works](https://github.com/bitsondatadev/iceberg/tree/new-docs/docs-new#build-process),
 and [install it 
locally](https://github.com/bitsondatadev/iceberg/tree/new-docs/docs-new#install)
 to get a grasp of the mechanics involved in the deployment and see if you 
agree with it or have any concerns. You should also poke around a bit to verify 
I didn't break many permalinks.
   
   This will not be deployed once merged, just give us an initial base for the 
new docs to work from. Later I will start working on the grammar fixes and 
adding [Vale, a prose linter](https://vale.sh/) that can abide by various 
grammar and style standards that we'd like to enforce. 
   
   Let me know if this makes sense.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to