bitsondatadev commented on code in PR #8659: URL: https://github.com/apache/iceberg/pull/8659#discussion_r1338430425
########## docs-new/.github/workflows/ci.yml: ########## @@ -0,0 +1,29 @@ +name: ci +on: + push: + branches: + - master Review Comment: > This would mean that it shows features that haven't been released yet. Not on the live site. I assumed that this build would only trigger on a release, so (latest) and the current version (e.g. 1.3.1 today) would just be duplicate docs (Unfortunately redirects from `latest` > `<version>` that maintain the `/docs/latest/` url would require some fancy DNS records that @rdblue said we should avoid for now). Later, we should defnitely consider adding a (nightly) or (dev) build and we would label that as such. For now, just assume that we only build this during a release. Unless the concern is around when people build the site locally. @nastra also brought this point up to me directly but I forgot to add this in the design so thanks for bringing this up so I can explain it here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
