Fokko commented on code in PR #8587:
URL: https://github.com/apache/iceberg/pull/8587#discussion_r1337617299
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol
org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @
org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?>
org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @
org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
I reran revapi for 1.11.3 release, and this time it didn't move any lines 🤔
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol
org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @
org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?>
org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @
org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
I reran revapi for 1.11.3 release, and this time it didn't move any lines 🤔
##########
.palantir/revapi.yml:
##########
@@ -857,6 +853,16 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.MergingSnapshotProducer<ThisT>::setNewFilesSequenceNumber(long)\
\ @ org.apache.iceberg.StreamingDelete"
justification: "Removing deprecated code"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method org.apache.avro.generic.GenericEnumSymbol
org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @
org.apache.iceberg.avro.UUIDConversion"
+ new: "method org.apache.avro.generic.GenericEnumSymbol<?>
org.apache.avro.Conversion<T>::toEnumSymbol(T,\
+ \ org.apache.avro.Schema, org.apache.avro.LogicalType) @
org.apache.iceberg.avro.UUIDConversion"
+ justification: "Add generic"
+ - code: "java.method.visibilityReduced"
Review Comment:
I reran revapi for the 1.11.3 release, and this time it didn't move any
lines 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
