[GitHub] [iceberg] Fokko commented on pull request #8625: Core: Avro writers use BlockingBinaryEncoder to enable array/map size calculations.

Mon, 25 Sep 2023 09:35:08 -0700 


Fokko commented on PR #8625:
URL: https://github.com/apache/iceberg/pull/8625#issuecomment-1734099517

   Removed another copy and introduced threadlocale, and we're close to the 
original:
   
   ```python
   ➜  iceberg git:(fd-add-benchmark) ✗ python3
   Python 3.11.5 (main, Aug 24 2023, 15:09:45) [Clang 14.0.3 
(clang-1403.0.22.14.1)] on darwin
   Type "help", "copyright", "credits" or "license" for more information.
   >>> with_threadlocale = [
   ...     26.181581084,
   ...     26.2257085,
   ...     26.292216292,
   ...     25.931295708,
   ...     25.773379833
   ... ]
   >>> sum(with
   with              with_threadlocale
   >>> sum(with_threadlocale) / 5
   26.080836283399996
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to