liurenjie1024 commented on PR #62: URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1733107722
> > This is a builder tailored for `CreateTable`, why not just put the check in builder? > > Maybe the builder approach is ok. But in my opinion, the 'CreateTable' case is a major case of constructing the TableMetadata struct from scratch. So it would be nice to have a tailored (and guided) method. Any software that supports CREATE TABLE for Iceberg would need that function, and unless the method is provided they must write the function in a very similar manner. Maybe it's just a matter of preference. I prefer the builder approach since the transaction actions may also need to modify table metadata, such as add schema, add snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
