clettieri commented on PR #8192:
URL: https://github.com/apache/iceberg/pull/8192#issuecomment-1728162582
> @clettieri, sorry it took so long to get back to this PR.
>
> Could you, please, add tests that the new name is also supported in CREATE
TABLE statements too? I believe this change only covers ALTER TABLE. In
addition, this PR should be rebased and include Spark 3.5.
Hey @aokolnychyi, I can rebase and include Spark 3.5 👍🏼 .
Regarding the CREATE TABLE tests though, I don't see any for the previous
transform functions and am unclear what new functionality they would test
compared to what we have now. The current tests seem sufficient IMO to
validate the transform functions can be called. Am I missing something here?
Should I create a new test class to very creating tables with these transform
functions succeed?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
