amogh-jahagirdar commented on code in PR #8548:
URL: https://github.com/apache/iceberg/pull/8548#discussion_r1321879233
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -329,6 +326,8 @@ def _get_fs(self, scheme: str) -> FileSystem:
hdfs_kwargs["user"] = user
if kerb_ticket := self.properties.get(HDFS_KERB_TICKET):
hdfs_kwargs["kerb_ticket"] = kerb_ticket
+ from pyarrow.fs import HadoopFileSystem
Review Comment:
Same nit as above, I think we can move it right after the elif
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -317,6 +312,8 @@ def _get_fs(self, scheme: str) -> FileSystem:
if proxy_uri := self.properties.get(S3_PROXY_URI):
client_kwargs["proxy_options"] = proxy_uri
+ from pyarrow.fs import S3FileSystem
Review Comment:
I guess we can move it to line 304 (after the if confirms we need to use the
S3FileSystem)? feels a bit more readable rather than importing more lazily. but
not strongly opinionated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
