wangtaohz commented on PR #8494:
URL: https://github.com/apache/iceberg/pull/8494#issuecomment-1713367994
> changes make sense, can you please add a simple
assertThat(lockManager.release(null, ownerId)).isTrue(); check to
TestInMemoryLockManager#testReleaseAndAcquire()?
Thanks for your reply!
I would be happy to add some test cases, but if I understand correctly, the
test for `assertThat(lockManager.release(null, ownerId)).isTrue();` will fail,
because `entityId` cannot be null when calling `release` and get it from
`LOCKS`.
```
@Override
public boolean release(String entityId, String ownerId) {
InMemoryLockContent currentContent = LOCKS.get(entityId);
...
...
}
```
Do you mean that we should support releasing with a null value for the
`entityId`? @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
