RussellSpitzer commented on code in PR #8517:
URL: https://github.com/apache/iceberg/pull/8517#discussion_r1318702274


##########
docs/configuration.md:
##########
@@ -74,7 +74,7 @@ Iceberg tables support table properties to configure table 
behavior, like the de
 | write.metadata.metrics.column.col1                   | (not set)             
      | Metrics mode for column 'col1' to allow per-column tuning; none, 
counts, truncate(length), or full                                               
                                                 |
 | write.target-file-size-bytes                         | 536870912 (512 MB)    
      | Controls the size of files generated to target about this many bytes    
                                                                                
                                          |
 | write.delete.target-file-size-bytes                  | 67108864 (64 MB)      
      | Controls the size of delete files generated to target about this many 
bytes                                                                           
                                            |
-| write.distribution-mode                              | none                  
      | Defines distribution of write data: __none__: don't shuffle rows; 
__hash__: hash distribute by partition key ; __range__: range distribute by 
partition key or sort key if table has an SortOrder |
+| write.distribution-mode                              | hash                  
      | Defines distribution of write data: __none__: don't shuffle rows; 
__hash__: hash distribute by partition key ; __range__: range distribute by 
partition key or sort key if table has an SortOrder |

Review Comment:
   Let's say the default is hash ... or "depends"?  I still think none is wrong 
since almost no one is using unpartitioned tables



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to