ZENOTME commented on PR #56: URL: https://github.com/apache/iceberg-rust/pull/56#issuecomment-1709556288
And I find some place is inconsistent with spec. 1. https://iceberg.apache.org/spec/#manifests:~:text=504-,added_files_count,-int In partice, this field in avro is **added_data_files_count** same thing exist in: existing_files_count, deleted_files_count 2. > [Optional fields, **array elements**, and map values must be wrapped in an Avro union with null. This is the only union type allowed in Iceberg data files.](https://iceberg.apache.org/spec/#avro:~:text=Optional%20fields%2C%20array%20elements%2C%20and%20map%20values%20must%20be%20wrapped%20in%20an%20Avro%20union%20with%20null.%20This%20is%20the%20only%20union%20type%20allowed%20in%20Iceberg%20data%20files.) ``` manifest_list: partitions: `list<508: field_summary>` ``` Actually this field_summary field is not a optional value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
