Fokko commented on PR #8374: URL: https://github.com/apache/iceberg/pull/8374#issuecomment-1704404610
> Schema ID is not being assigned in commit, which corrupts metadata This was a great catch, updated this! The REST Catalog actually handled this correctly, but now it is also fixed and tested outside of the rest catalog. > Tests are run as integration tests, but most could be converted to unit tests that call _apply I ported some tests outside of the integration tests as well. As [mentioned above](https://github.com/apache/iceberg/pull/8374#discussion_r1314249767) I really like testing against the REST catalog, since uses the same public API that the customer uses (which is a good thing from an OOP perspective), but we're testing much more code than we actually need. I also ported some test back to avoid having only integration tests, but the majority is still IT tests because I prefer them. Let me know if you want me to port the rest back as well. > update_column always creates an entry in changes even if the change should be a noop Added and tested as well, also removed the `make_required` and `set_doc` operations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
