rdblue commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1314289580
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -91,41 +111,325 @@ default ViewMetadata checkAndNormalize() {
"Unsupported format version: %s",
formatVersion());
- Preconditions.checkArgument(versions().size() > 0, "Invalid view versions:
empty");
- Preconditions.checkArgument(history().size() > 0, "Invalid view history:
empty");
- Preconditions.checkArgument(schemas().size() > 0, "Invalid schemas:
empty");
+ return this;
Review Comment:
Why does this method return `this`? Other check methods are defined as
`default void check() { ... }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
