ZENOTME commented on issue #55:
URL: https://github.com/apache/iceberg-rust/issues/55#issuecomment-1702530287
> This gives concrete implementation more chances to do optimization
> Good points, @liurenjie1024. I think it would make sense to have
load_table, load_view and load_entity. Just that for SELECT queries it would be
good to use load_entity. For cases where the query engine knows whether it's a
table or a view it can call load_table and load_view.
Agree with having `load_entity`, `load_table` and `load_view`.
> For cases where the query engine knows whether it's a table or a view it
can call load_table and load_view.
What I concern is whether is way will cause redundant code.🤔 E.g.
```
if we can determine is table :
let table = load_table
<process1>
else if we can determine is view :
let view = load_view
<process2>
else
let tableike = load_entity
<process3>
```
`<process1>`,`<process2>`,`<process3>` may be redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
