Xuanwo commented on code in PR #53:
URL: https://github.com/apache/iceberg-rust/pull/53#discussion_r1312643293
##########
crates/iceberg/src/error.rs:
##########
@@ -44,6 +44,10 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
FeatureUnsupported,
+ /// Error during io operation.
+ ///
+ /// This error is returned when doing io operations.
+ IoError,
Review Comment:
Makes sense, split into `Unrecoverable` and `Recoverable` makes sense to me.
By the way, OpenDAL handles recoverable errors internally with `RetryLayer`,
so those error will become `Unrecoverable` after retry. Maybe we can use
`Unexpected` for now first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
