ConeyLiu commented on code in PR #8423:
URL: https://github.com/apache/iceberg/pull/8423#discussion_r1312614639
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/JobGroupUtils.java:
##########
@@ -39,11 +40,16 @@ public static JobGroupInfo getJobGroupInfo(SparkContext
sparkContext) {
return new JobGroupInfo(groupId, description,
Boolean.parseBoolean(interruptOnCancel));
}
- public static void setJobGroupInfo(SparkContext sparkContext, JobGroupInfo
info) {
- sparkContext.setLocalProperty(JOB_GROUP_ID, info.groupId());
+ public static void setJobGroupInfo(
+ SparkContext sparkContext, JobGroupInfo info, Boolean override) {
Review Comment:
what's the reason to use the boxed `Boolean`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
