liurenjie1024 commented on issue #52: URL: https://github.com/apache/iceberg-rust/issues/52#issuecomment-1702017174
Hi, @y0psolo Thanks for the contribution. We had a discussion in #3 about the style of public api, in conclusion 1. For complex structs such as TableMetadata, Sanpshot, Schema, etc, we prefer not to expose pub field, but only necessary methods 2. I'm ok with builder pattern. cc @Xuanwo @ZENOTME @JanKaul Any comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
