liurenjie1024 commented on code in PR #42:
URL: https://github.com/apache/iceberg-rust/pull/42#discussion_r1308557984
##########
crates/iceberg/src/transform/temporal.rs:
##########
@@ -28,24 +28,24 @@ use arrow::{
use chrono::Datelike;
use std::sync::Arc;
-/// 719163 is the number of days from 0000-01-01 to 1970-01-01
-const EPOCH_DAY_FROM_CE: i32 = 719163;
-const DAY_PER_SECOND: f64 = 0.0000115741;
-const HOUR_PER_SECOND: f64 = 1_f64 / 3600.0;
-const BASE_YEAR: i32 = 1970;
+const DAY_FROM_UNIX_EPOCH: i32 = 719163;
Review Comment:
Add comments for all these constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
