ajantha-bhat commented on code in PR #8413:
URL: https://github.com/apache/iceberg/pull/8413#discussion_r1308279086
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -153,13 +153,12 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
// to catch all kinds of network errors (e.g. connection reset). Network
code implementation
// details and all kinds of network devices can induce unexpected
behavior. So better be
// safe than sorry.
- delete = false;
throw new CommitStateUnknownException(ex);
} catch (NessieNotFoundException ex) {
throw new RuntimeException(
Review Comment:
we can delete in this case also right? As it is definitely a failure to
commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
