Xuanwo commented on code in PR #40: URL: https://github.com/apache/iceberg-rust/pull/40#discussion_r1308156204
########## crates/iceberg/src/lib.rs: ########## @@ -18,6 +18,7 @@ //! Native Rust implementation of Apache Iceberg #![deny(missing_docs)] +#![allow(dead_code)] Review Comment: Adding this at the library level may result in unexpected dead code within our library. Instead, we could consider adding it at the module level, such as `avro`. Additionally, we should ensure that these additions are eventually removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
