amogh-jahagirdar commented on code in PR #8370:
URL: https://github.com/apache/iceberg/pull/8370#discussion_r1308086651
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -67,6 +67,14 @@ public class S3FileIOProperties implements Serializable {
*/
public static final String SSE_TYPE_KMS = "kms";
+ /**
+ * S3 DSSE-KMS encryption.
+ *
+ * <p>For more details:
+ *
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingDSSEncryption.html
+ */
+ public static final String DSSE_TYPE_KMS = "kms.dsse";
Review Comment:
The naming `kms.dsse` implies that DSSE will exist as a property namespace
under KMS. Are there any other configurations which would actually go under
this namespace? If not should we just call it `dsse-kms`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
