lirui-apache commented on PR #5887: URL: https://github.com/apache/iceberg/pull/5887#issuecomment-1693101384
Hey @Heltman , I wonder whether the changes made here are still just best effort to cancel the future tasks. Suppose `close()` and `submitNextTask()` are called concurrently, it's possible that `close()` is invoked after `submitNextTask()` checks the `closed` flag, but before it can really submit a new task. Then the newly submitted task can run and add elements to the queue, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
