rdblue commented on code in PR #8374:
URL: https://github.com/apache/iceberg/pull/8374#discussion_r1304798205
##########
python/pyiceberg/table/__init__.py:
##########
@@ -527,8 +519,13 @@ def history(self) -> List[SnapshotLogEntry]:
"""Get the snapshot history of this table."""
return self.metadata.snapshot_log
- def update_schema(self) -> UpdateSchema:
- return UpdateSchema(self.schema(), self)
+ def update_schema(self, allow_incompatible_changes: bool = False,
case_sensitive: bool = True) -> UpdateSchema:
+ return UpdateSchema(self,
allow_incompatible_changes=allow_incompatible_changes,
case_sensitive=case_sensitive)
+
+ def _do_commit(self, request: CommitTableRequest) -> None:
Review Comment:
I think it would make more sense to pass requirements and updates. The
identifier is already in the table and this can create the request. Or maybe
the request should be created in `catalog._commit_table`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
