aokolnychyi commented on code in PR #8388:
URL: https://github.com/apache/iceberg/pull/8388#discussion_r1304769978
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -87,7 +87,7 @@ public CloseableIterable<FileScanTask> doPlanFiles() {
manifestGroup = manifestGroup.ignoreResiduals();
}
- if (dataManifests.size() > 1 && shouldPlanWithExecutor()) {
+ if (shouldPlanWithExecutor() && (dataManifests.size() > 1 ||
deleteManifests.size() > 1)) {
Review Comment:
Data and deletes are planned separately. If we are scanning 1 data manifest,
it does not mean we shouldn't parallelize the planing of deletes.
```
ManifestGroup planWith(ExecutorService newExecutorService) {
this.executorService = newExecutorService;
deleteIndexBuilder.planWith(newExecutorService);
return this;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
