danielcweeks commented on code in PR #8365:
URL: https://github.com/apache/iceberg/pull/8365#discussion_r1302487167
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -328,6 +334,27 @@ public SdkHttpFullRequest sign(
return mutableRequest.build();
}
+ private String body(SdkHttpFullRequest request) {
+ if (shouldAddBody(request) && request.contentStreamProvider().isPresent())
{
+ try (InputStream is = request.contentStreamProvider().get().newStream())
{
+ return IoUtils.toUtf8String(is);
+ } catch (IOException e) {
+ throw new UncheckedIOException("Failed to set body for S3 sign
request", e);
Review Comment:
I think it's possible that you could sign if the body isn't present (it
really depends on the level of checking the service performs). I feel like we
would be ok logging and letting the service deny if the body isn't present. I
would probably put it at a much lower logging level (debug?) because it will
either be ok without the body, or be rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
