dramaticlly commented on code in PR #8337: URL: https://github.com/apache/iceberg/pull/8337#discussion_r1298721830
########## docs/partitioning.md: ########## @@ -92,7 +92,7 @@ This leads to several problems: Iceberg produces partition values by taking a column value and optionally transforming it. Iceberg is responsible for converting `event_time` into `event_date`, and keeps track of the relationship. -Table partitioning is configured using these relationships. The `logs` table would be partitioned by `date(event_time)` and `level`. +Table partitioning is configured using these relationships. The `logs` table would be partitioned by `date(event_time)` and `level`. Since the `day` partition transform returns the number of days from 1970-01-01, this table will be partitioned by calendar day and not day of the month. Review Comment: I think maybe better to link the iceberg spec here https://iceberg.apache.org/spec/#partition-transforms, it's pretty clear if one want to know more about all types of partitions transformation <img width="995" alt="image" src="https://github.com/apache/iceberg/assets/5961173/51350c3f-93f3-4b2b-ab65-e352f47d0945";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
