aokolnychyi commented on code in PR #8336:
URL: https://github.com/apache/iceberg/pull/8336#discussion_r1296200612
##########
core/src/main/java/org/apache/iceberg/OffsetsAwareSplitScanTaskIterator.java:
##########
@@ -44,12 +39,9 @@ class OffsetsAwareSplitScanTaskIterator<T extends ScanTask>
implements SplitScan
long parentTaskLength,
List<Long> offsetList,
SplitScanTaskCreator<T> splitTaskCreator) {
- Preconditions.checkArgument(
- OFFSET_ORDERING.isStrictlyOrdered(offsetList), "Offsets must be sorted
in asc order");
-
this.parentTask = parentTask;
this.splitTaskCreator = splitTaskCreator;
- this.offsets = ImmutableList.copyOf(offsetList);
Review Comment:
I don't think we need to copy the list of offsets. This was introduced
[here](https://github.com/apache/iceberg/pull/204#discussion_r290077463) and
was flagged during the initial review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
