manuzhang commented on code in PR #8316:
URL: https://github.com/apache/iceberg/pull/8316#discussion_r1295355332


##########
docs/spark-queries.md:
##########
@@ -270,17 +270,22 @@ order by made_current_at
 
 ### Files
 
-To show a table's current data files:
+To show a table's current files:
 
 ```sql
 SELECT * FROM prod.db.table.files;
 ```
 
-|content|file_path                                                             
                                                                      
|file_format|spec_id|partition|record_count|file_size_in_bytes|column_sizes     
 |value_counts    |null_value_counts|nan_value_counts|lower_bounds           
|upper_bounds           |key_metadata|split_offsets|equality_ids|sort_order_id|
+| content | file_path | file_format | spec_id | record_count | 
file_size_in_bytes | column_sizes | value_counts | null_value_counts | 
nan_value_counts | lower_bounds | upper_bounds | key_metadata | split_offsets | 
equality_ids | sort_order_id | readable_metrics |
 | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | 
-- | -- |
-| 0 | s3:/.../table/data/00000-3-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet 
| PARQUET   | 0  | {1999-01-01, 01} | 1            | 597                | [1 -> 
90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0]  | []               | [1 -> 
, 2 -> c] | [1 -> , 2 -> c] | null         | [4]           | null | null |
-| 0 | s3:/.../table/data/00001-4-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet 
| PARQUET   | 0  | {1999-01-01, 02} | 1            | 597                | [1 -> 
90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0]  | []               | [1 -> 
, 2 -> b] | [1 -> , 2 -> b] | null         | [4]           | null | null |
-| 0 | s3:/.../table/data/00002-5-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet 
| PARQUET   | 0  | {1999-01-01, 03} | 1            | 597                | [1 -> 
90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0]  | []               | [1 -> 
, 2 -> a] | [1 -> , 2 -> a] | null         | [4]           | null | null |
+| 0 | 
s3:/.../table/data/00042-3-a9aa8b24-20bc-4d56-93b0-6b7675782bb5-00001.parquet | 
PARQUET | 0 | 1 | 652 | {1:52,2:48} | {1:1,2:1} | {1:0,2:0} | {} | {1:,2:d} | 
{1:,2:d} | NULL | [4] | NULL | 0 | 
{"data":{"column_size":48,"value_count":1,"null_value_count":0,"nan_value_count":null,"lower_bound":"d","upper_bound":"d"},"id":{"column_size":52,"value_count":1,"null_value_count":0,"nan_value_count":null,"lower_bound":1,"upper_bound":1}}
 |
+| 0 | 
s3:/.../table/data/00000-0-f9709213-22ca-4196-8733-5cb15d2afeb9-00001.parquet | 
PARQUET | 0 | 1 | 643 | {1:46,2:48} | {1:1,2:1} | {1:0,2:0} | {} | {1:,2:a} | 
{1:,2:a} | NULL | [4] | NULL | 0 | 
{"data":{"column_size":48,"value_count":1,"null_value_count":0,"nan_value_count":null,"lower_bound":"a","upper_bound":"a"},"id":{"column_size":46,"value_count":1,"null_value_count":0,"nan_value_count":null,"lower_bound":1,"upper_bound":1}}
 | 
+| 0 | 
s3:/.../table/data/00001-1-f9709213-22ca-4196-8733-5cb15d2afeb9-00001.parquet | 
PARQUET | 0 | 2 | 644 | {1:49,2:51} | {1:2,2:2} | {1:0,2:0} | {} | {1:,2:b} | 
{1:,2:c} | NULL | [4] | NULL | 0 | 
{"data":{"column_size":51,"value_count":2,"null_value_count":0,"nan_value_count":null,"lower_bound":"b","upper_bound":"c"},"id":{"column_size":49,"value_count":2,"null_value_count":0,"nan_value_count":null,"lower_bound":2,"upper_bound":3}}
 |
+| 1 | 
s3:/.../table/data/00081-4-a9aa8b24-20bc-4d56-93b0-6b7675782bb5-00001-deletes.parquet
 | PARQUET | 0 | 1 | 1560 | {2147483545:46,2147483546:152} | 
{2147483545:1,2147483546:1} | {2147483545:0,2147483546:0} | {} | 
{2147483545:,2147483546:s3:/.../table/data/00000-0-f9709213-22ca-4196-8733-5cb15d2afeb9-00001.parquet}
 | 
{2147483545:,2147483546:s3:/.../table/data/00000-0-f9709213-22ca-4196-8733-5cb15d2afeb9-00001.parquet}
 | NULL | [4] | NULL | NULL | 
{"data":{"column_size":null,"value_count":null,"null_value_count":null,"nan_value_count":null,"lower_bound":null,"upper_bound":null},"id":{"column_size":null,"value_count":null,"null_value_count":null,"nan_value_count":null,"lower_bound":null,"upper_bound":null}}
 |
+
+Content `0`  means it's a data file and content `1` a position-deletes file 
for [v2 format](../configuration/#reserved-table-properties). They also can be 
inspected individualy from `prod.db.table.data_files` and 
`prod.db.table.delete_files`.

Review Comment:
   1. Are equality deletes typically used with Spark query? 
   2. I'm copying `position-deletes file` from description in 
https://iceberg.apache.org/spec/#manifests
   ```
   Type of content stored by the data file: data, equality deletes, or position 
deletes (all v1 files are data files)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to