Fokko commented on code in PR #7782:
URL: https://github.com/apache/iceberg/pull/7782#discussion_r1294982216
##########
python/pyiceberg/table/snapshots.py:
##########
@@ -59,34 +58,19 @@ class Summary(IcebergBaseModel):
like snapshot expiration, to skip processing certain snapshots.
"""
- __root__: Dict[str, Union[str, Operation]]
+ operation: Operation = Field()
_additional_properties: Dict[str, str] = PrivateAttr()
- @root_validator
Review Comment:
A lot of changes here because the additional fields in the operation `dict`
are considered properties. Since the `@root_validator` is not there anymore, we
completely had to rewrite this. For the better I'd say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
