aokolnychyi commented on code in PR #8313:
URL: https://github.com/apache/iceberg/pull/8313#discussion_r1294825146
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -178,6 +185,32 @@ private WriterFactory createWriterFactory() {
// broadcast the table metadata as the writer factory will be sent to
executors
Broadcast<Table> tableBroadcast =
sparkContext.broadcast(SerializableTableWithSize.copyOf(table));
+ Map<String, String> writeProperties = Maps.newHashMap();
Review Comment:
What about adding a separate method for this? We could then call it directly
in `new WriterFactory(...)`.
```
private Map<String, String> writeProperties() {
Map<String, String> properties = Maps.newHashMap();
...
return properties;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
