rdblue commented on code in PR #8088:
URL: https://github.com/apache/iceberg/pull/8088#discussion_r1294047348
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -63,4 +63,9 @@ private SparkSQLProperties() {}
// Controls the WAP branch used for write-audit-publish workflow.
// When set, new snapshots will be committed to this branch.
public static final String WAP_BRANCH = "spark.wap.branch";
+
+ // Controls whether to push down Iceberg system function
+ public static final String SYSTEM_FUNC_PUSH_DOWN_ENABLED =
Review Comment:
I went through some of those old commits over the weekend and I think that
converting `StaticInvoke` when necessary is a good idea. I think we may also be
able to simplify some of the rules, since the pushdown logic needs additional
handling for reasons that don't necessarily limit rules for converting
expressions. I'd like to see if we can simplify the rules to not have quite so
many special cases.
And I also think we don't need to use the special matchers since we don't
have special logic. We can probably just use the logical plans directly if need
to support specific plan nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
