nastra commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1293208119
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java:
##########
@@ -132,16 +133,16 @@ public static ViewMetadata fromJson(JsonNode json) {
historyEntries.add(ViewHistoryEntryParser.fromJson(vLog));
}
- return ImmutableViewMetadata.builder()
- .location(location)
- .currentVersionId(currentVersionId)
- .properties(properties)
- .versions(versions)
- .schemas(schemas)
- .currentSchemaId(currentSchemaId)
- .history(historyEntries)
- .formatVersion(formatVersion)
- .build();
+ return ImmutableViewMetadata.of(
+ formatVersion,
+ location,
+ currentSchemaId,
+ schemas,
+ currentVersionId,
+ versions,
+ historyEntries,
+ properties,
+ ImmutableList.of());
Review Comment:
we haven't been tracking that for Views so far but it was on my list to be
added once we need it. That being said, I'll handle this in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
