nastra commented on code in PR #8270:
URL: https://github.com/apache/iceberg/pull/8270#discussion_r1289842398
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -133,6 +133,10 @@ private FileIO io(String location) {
String impl = implFromLocation(location);
FileIO io = ioInstances.get(impl);
if (io != null) {
+ // re-apply the config in case it's null after Kryo serialization
+ if (io instanceof HadoopConfigurable && ((HadoopConfigurable)
io).getConf() == null) {
Review Comment:
not sure if this could be an issue, but we could try and switch
`ioInstances` to a concurrent hash map instead of using locks. @ConeyLiu would
you be interested in doing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
