ConeyLiu commented on code in PR #8278:
URL: https://github.com/apache/iceberg/pull/8278#discussion_r1289485137
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -160,6 +173,20 @@ DeleteFile[] forDataFile(long sequenceNumber, DataFile
file) {
.toArray(DeleteFile[]::new);
}
+ private DeleteFile[] limitWithoutColumnStatsFiltering(
+ long sequenceNumber, DeleteFileGroup partitionDeletes) {
+
+ if (partitionDeletes == null) {
+ return globalDeletes.filter(sequenceNumber);
+ } else if (globalDeletes == null) {
+ return partitionDeletes.filter(sequenceNumber);
+ } else {
+ DeleteFile[] matchingGlobalDeletes =
globalDeletes.filter(sequenceNumber);
+ DeleteFile[] matchingPartitionDeletes =
partitionDeletes.filter(sequenceNumber);
+ return ObjectArrays.concat(matchingGlobalDeletes,
matchingPartitionDeletes, DeleteFile.class);
Review Comment:
@aokolnychyi I think we should do some benchmarks about the performance of
the table scan while disabling the table property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
