aokolnychyi commented on code in PR #8278:
URL: https://github.com/apache/iceberg/pull/8278#discussion_r1289348761
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -604,7 +664,28 @@ private static class DeleteFileGroup {
this.files = files;
}
+ public DeleteFile[] filter(long seq) {
Review Comment:
There is no need to use the Stream API (which has overhead) if column stats
filtering is disabled. Take a look at the flamegraph below that uses streams
without column stats filtering.
<img width="2560" alt="image"
src="https://github.com/apache/iceberg/assets/6235869/b7b46915-3c6c-4f89-bacd-c156a9135e37";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
