ConeyLiu commented on code in PR #8088:
URL: https://github.com/apache/iceberg/pull/8088#discussion_r1282955480
##########
orc/src/main/java/org/apache/iceberg/orc/ExpressionToSearchArgument.java:
##########
@@ -270,7 +271,8 @@ public <T> Action notStartsWith(Bound<T> expr, Literal<T>
lit) {
@Override
public <T> Action predicate(BoundPredicate<T> pred) {
- if (UNSUPPORTED_TYPES.contains(pred.ref().type().typeId())) {
+ if (UNSUPPORTED_TYPES.contains(pred.ref().type().typeId())
+ || !(pred.term() instanceof BoundReference)) {
Review Comment:
The reason is that we support push-down transform functions now. However,
the file format can't handle such filters. The reason for parquet too. Another
choice is we don't push down those transform functions for unpartitioned tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
