Fokko commented on PR #16: URL: https://github.com/apache/iceberg-rust/pull/16#issuecomment-1663346808
> Yes, we will implement our own catalog trait based on this client. Shouldn't we first create a trait and then the implementation? I'm not sure if this is the right approach. There is a lot of stuff in here that will be duplicated. For example, Schema, Types, Metadata (it maps 1 to 1 with the Iceberg metadata), Snapshots, PartitionSpecs, SortFields. I don't think we want to have a Schema in the rest catalog package, and a general Schema, because then we would need to convert the objects vica versa. There is a working REST catalog available at: https://github.com/tabular-io/docker-spark-iceberg/tree/main/spark Would be awesome if we start testing if we can actually pull a table from there, including tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
