RussellSpitzer commented on PR #7607: URL: https://github.com/apache/iceberg/pull/7607#issuecomment-1662998068
Took a look today, as noted by @ConeyLiu we have a lot of code style issues to clean up here. The tests are also a little confusing because I think some of them are covering overall merge behavior and some cover the api. Let's try to minimize the surface area of this PR if we can. The API itself looks ok to me, I left a few comments there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
