RussellSpitzer commented on code in PR #7607:
URL: https://github.com/apache/iceberg/pull/7607#discussion_r1282425375
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -214,15 +214,15 @@ protected void createOrReplaceView(String name, String
jsonData) {
}
protected void createOrReplaceView(String name, String schema, String
jsonData) {
- Dataset<Row> ds = toDS(schema, jsonData);
+ Dataset<Row> ds = createDataset(schema, jsonData);
ds.createOrReplaceTempView(name);
}
protected <T> void createOrReplaceView(String name, List<T> data, Encoder<T>
encoder) {
spark.createDataset(data, encoder).createOrReplaceTempView(name);
}
- private Dataset<Row> toDS(String schema, String jsonData) {
+ protected Dataset<Row> createDataset(String schema, String jsonData) {
Review Comment:
I would agree that we shouldn't change method names if we can help it in a
pr that is already quite large. I would just keep it as createDataset and do
the change to toDS in another pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
