Fokko commented on code in PR #8067: URL: https://github.com/apache/iceberg/pull/8067#discussion_r1280322553
########## python/pyiceberg/avro/reader.py: ########## @@ -153,8 +154,8 @@ def skip(self, decoder: BinaryDecoder) -> None: class DateReader(Reader): - def read(self, decoder: BinaryDecoder) -> int: - return decoder.read_int() + def read(self, decoder: BinaryDecoder) -> date: Review Comment: Yes, I reverted this, and also fixed this for the `datetime`, that would actually break. I've also added some integration tests to cover this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
