ConeyLiu commented on PR #7886: URL: https://github.com/apache/iceberg/pull/7886#issuecomment-1659518465
Thanks @holdenk for your interest and comments. > Personally, I have some questions about how the filters are working for the delete use case, and I think it might be good to have some tests for the filter pushdown on deletes since (from my first pass reading of the code) it might throw an exception. I mentioned a little in the descriptions. ``` This is the first part code. It changes filters to V2 filters and adds support to convert system functions wrapped in Spark UserDefinedScalarFunc to Iceberg expressions. In the following PR will add a rule to convert the system function call to ApplyFunctionExpression which could be pushed down to the data source. ``` Actually, I have submitted some of the code for the rule and SQL UTs. However, they are split out to keep the PR small for review. I have a follow-up #8088 here and will be moved forward when this PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
