nastra commented on code in PR #8099: URL: https://github.com/apache/iceberg/pull/8099#discussion_r1279434641
########## core/src/main/java/org/apache/iceberg/actions/BaseSnapshotTable.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.immutables.value.Value; + [email protected] +// https://github.com/immutables/immutables/issues/291 does not apply here because we're not adding +// any Immutable-specific class to the classpath +@SuppressWarnings("ImmutablesStyle") [email protected](typeImmutableEnclosing = "ImmutableSnapshotTable") +public interface BaseSnapshotTable extends SnapshotTable { Review Comment: I've looked closer into this and I don't think this is actually a direct issue of using Immutables per-se, but rather something with javac. The generated class looks identical with/without the `ImplementationVisibility` and the javac warning won't cause any issues for consuming clients. I went ahead an made all relevant interfaces package-protected and specified the visibility of the generated Class/Builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
