aokolnychyi commented on PR #8164: URL: https://github.com/apache/iceberg/pull/8164#issuecomment-1656434619
I have doubts about adding this config at the SQL level. It won't really help the use cause you mentioned above. It will disable both distribution and ordering. In regular writes, you can add a manual repartition step but not in row-level operations. Not doing a repartition/rebalance step is probably not a great idea. I see multiple options: - Leave as is where no local sort is triggered if fanout writers are enabled and the table is unsorted. - Never request a local sort if fanout writers are enabled (even when the table is sorted). - Add a SQL property like `spark.sql.iceberg.use-table-ordering-with-fanout-writers` to control this behavior. I am probably inclined to go with option 1 or 2. Any thoughts, @chenjunjiedada @RussellSpitzer @szehon-ho? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
