aokolnychyi commented on code in PR #8172:
URL: https://github.com/apache/iceberg/pull/8172#discussion_r1277168486
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -394,16 +410,22 @@ Builder specsById(Map<Integer, PartitionSpec>
newSpecsById) {
}
Builder filterData(Expression newDataFilter) {
+ Preconditions.checkArgument(
Review Comment:
If there is a use case in the future where we need to support these filters,
we can add implement these methods. That said, it won't be needed for
distributed planning and it won't be trivial.
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -394,16 +410,22 @@ Builder specsById(Map<Integer, PartitionSpec>
newSpecsById) {
}
Builder filterData(Expression newDataFilter) {
+ Preconditions.checkArgument(
Review Comment:
If there is a use case in the future where we need to support these filters,
we can implement these methods. That said, it won't be needed for distributed
planning and it won't be trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
