manuzhang commented on code in PR #8163:
URL: https://github.com/apache/iceberg/pull/8163#discussion_r1277167540
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/procedures/SetCurrentSnapshotProcedure.java:
##########
@@ -42,7 +43,8 @@ class SetCurrentSnapshotProcedure extends BaseProcedure {
private static final ProcedureParameter[] PARAMETERS =
new ProcedureParameter[] {
ProcedureParameter.required("table", DataTypes.StringType),
- ProcedureParameter.required("snapshot_id", DataTypes.LongType)
+ ProcedureParameter.optional("snapshot_id", DataTypes.LongType),
+ ProcedureParameter.optional("tag", DataTypes.StringType)
Review Comment:
I don’t think “ref” is user facing and would rather add one more option for
“branch”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
