aokolnychyi commented on code in PR #8157:
URL: https://github.com/apache/iceberg/pull/8157#discussion_r1275736380
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -66,43 +66,50 @@
* file.
*/
class DeleteFileIndex {
+ private static final DeleteFile[] NO_DELETES = new DeleteFile[0];
+
private final Map<Integer, PartitionSpec> specsById;
private final Map<Integer, Types.StructType> partitionTypeById;
private final Map<Integer, ThreadLocal<StructLikeWrapper>> wrapperById;
- private final long[] globalSeqs;
- private final DeleteFile[] globalDeletes;
- private final Map<Pair<Integer, StructLikeWrapper>, Pair<long[],
DeleteFile[]>>
- sortedDeletesByPartition;
+ private final DeleteFileGroup globalDeletes;
+ private final Map<Pair<Integer, StructLikeWrapper>, DeleteFileGroup>
deletesByPartition;
+ private final boolean isEmpty;
DeleteFileIndex(
- Map<Integer, PartitionSpec> specsById,
+ Map<Integer, PartitionSpec> specs,
Review Comment:
I feel like it is OK to do given that this PR already contains a few
cosmetic changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
