rdblue commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1275574605
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -63,4 +63,8 @@ private SparkSQLProperties() {}
// Controls the WAP branch used for write-audit-publish workflow.
// When set, new snapshots will be committed to this branch.
public static final String WAP_BRANCH = "spark.wap.branch";
+
+ public static final String PLANNING_MODE = "spark.sql.iceberg.planning-mode";
Review Comment:
It's a little strange to have a "planning mode" that doesn't affect deletes.
I'd say this should be the default for both (with the ability to override it
specifically for deletes like we do for other settings) or we should have one
for data and one for deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
