rdblue commented on code in PR #3231:
URL: https://github.com/apache/iceberg/pull/3231#discussion_r1275496582
##########
.palantir/revapi.yml:
##########
@@ -743,6 +743,12 @@ acceptedBreaks:
new: "method java.util.List<org.apache.iceberg.UpdateRequirement>
org.apache.iceberg.rest.requests.UpdateTableRequest::requirements()"
justification: "Signature changed to an interface, but this is safe
because\
\ of type erasure and the original type is always returned"
+ "1.3.0":
+ org.apache.iceberg:iceberg-core:
+ - code: "java.method.visibilityReduced"
+ old: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
+ new: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
+ justification: "Static utility class - should not have public
constructor"
Review Comment:
Is this needed? Can we just leave it as it was or is it now failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
