szehon-ho commented on code in PR #8111:
URL: https://github.com/apache/iceberg/pull/8111#discussion_r1271826919
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java:
##########
@@ -122,8 +123,8 @@ public void testDatePartition() throws Exception {
@Test
public void testBooleanPartition() throws Exception {
createTable("boolean");
- insertData(i -> i % 2 == 0, 2);
- testDanglingDelete(2);
+ insertData(PARTITION_COL, i -> i % 2 == 0, 2);
Review Comment:
Thanks, can also you make these methods have a default version that
delegates with PARTITION_COL?:
```
private void insertData(Function<Integer, ?> partitionValueFunction)
throws Exception {
insertData(partitionValueFunction, PARTITION_COL, NUM_DATA_FILES);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
