Fokko commented on code in PR #6906:
URL: https://github.com/apache/iceberg/pull/6906#discussion_r1271817859
##########
python/mkdocs/docs/configuration.md:
##########
@@ -74,13 +74,30 @@ For the FileIO there are several configuration options
available:
| Key | Example
| Description
|
| ----------------------- |
-----------------------------------------------------------------------------------------
|
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
| adlfs.connection-string |
AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqF...;BlobEndpoint=http://localhost/
| A [connection
string](https://learn.microsoft.com/en-us/azure/storage/common/storage-configure-connection-string).
This could be used to use FileIO with any adlfs-compatible object storage
service that has a different endpoint (like
[azurite](https://github.com/azure/azurite)). |
+
Review Comment:
Can you remove this unrelated change?
##########
python/mkdocs/docs/index.md:
##########
@@ -60,7 +60,8 @@ You can mix and match optional dependencies depending on your
needs:
| s3fs | S3FS as a FileIO implementation to interact with the object store
|
| adlfs | ADLFS as a FileIO implementation to interact with the object
store |
| snappy | Support for snappy Avro compression
|
+| gcs | GCS as the FileIO implementation to interact with the object
store |
Review Comment:
```suggestion
| gcsfs | GCS as the FileIO implementation to interact with the object
store |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
